Inspect the Code

📌 Your Tasks

• Use the Coding Defects Checklist to analyze the source code.
• Identify defects and log them in ReviewForm.doc.
• Propose fixes to improve code correctness and readability.

📌 Resources

🖥 Source Code

public class LongestPrimeSequence {
    private ArrayList l;
    private int start, length;
    
    public LongestPrimeSequence() {
        System.out.println("Long. Seq. empty ...");
    }
    
    public void setSequence(ArrayList l) {
        this.l = l;
    }
    
    public LongestPrimeSequence(ArrayList newL) {
        this.l = newL;
        this.start = -1;
        this.length = 0;
    }
    
    public int getStart() { return this.start; }
    public int getLength() { return this.length; }
    
    public boolean isPrime(int n) throws ValueException {
        boolean b = true;
        if(n < 0) {
            throw new ValueException("data not valid");
        }
        if(n < 2) {
            b = false;
        } else {
            int i = 2;
            while (i < (n / 2)) {
                if ((n % i) == 0) {
                    b = false;
                } else {
                    b = true;
                }
                i++;
            }
        }
        return b;
    }
    
    public void SolveLongestSequence() throws ValueException {
        int posI = -1, lengthI = 0, i = 0;
        int posF = -1, lengthF = 0;
        
        while(i < this.l.size()) {
            if(isPrime((int)this.l.get(i)) == true) {
                if(posI == -1) {
                    posI = i;
                    lengthI = 1;
                } else {
                    lengthI++;
                }
            } else {
                if(lengthI > lengthF) {
                    lengthF = lengthI;
                    posF = posI;
                }
            }
            i++;
        }
        
        this.start = posF;
        this.length = lengthF;
    }
}

📋 Code Phase Defects Checklist

Code	Defect Description
D_01	Decision logic or sequencing is incorrect.
D_02	Erroneous branching conditions.
D_03	Undefined loop terminations.
D_04	I/O format issues.
D_05	Function calls are incorrectly structured.
D_06	Confusion in parameter usage.
D_07	Comments

📄 Download the checklist
📥 Defects Checklist.pdf

📋 Example Completed Review Entry

Crt. No.	Checked Item	Issue	Suggestion
1	D_01 – Bad logic	Wheels turning like propellers	Fix logic for land movement
2	...	...	...

📄 Download the review form
📥 Review Form.doc